Add message definitions for removable storage device #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Juan Pablo Pino Bravo <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces new Protobuf message definitions to support telemetry and control for removable storage devices. Key changes include:
- Updated VideoStorageSpaceTel to include a field for removable storage information.
- Added the new RemovableStorageTel message for transmitting removable storage device data.
- Introduced new boolean flags in StorageSpace and added the FormatRemovableStorageDeviceCtrl message with appropriate documentation.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| protobuf_definitions/telemetry.proto | Added a new removable_space field to VideoStorageSpaceTel and defined RemovableStorageTel. |
| protobuf_definitions/message_formats.proto | Added two new boolean fields to indicate file system errors and read-only device status. |
| protobuf_definitions/control.proto | Added the FormatRemovableStorageDeviceCtrl message with detailed warnings about data loss. |
Co-Authored-By: Juan Pablo Pino Bravo <[email protected]>
jp-pino
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new message definitions for use with the new removable storage device.
The key improvements are:
RemovableStorageTelwith information about any connected removable storage deviceFormatRemovableStorageDeviceCtrlto format a storage deviceRemovableStorageErrorFlagslisting all the relevant error states for the deviceGuestPortDetachStatusis used to indicate weather a removable storage device is connected to the USB cable (when the water proof canister is attached, and a user optionally can have a USB storage device inside the canister).